darrell-k / slimserver

Server for Logitech Squeezebox players. This server is also called Logitech Media Server
Other
0 stars 0 forks source link

Don't duplicate composer name in the list when viewing works by composer #6

Open darrell-k opened 6 months ago

darrell-k commented 6 months ago

See https://forums.slimdevices.com/forum/developer-forums/developers/1655727-adding-classical-work-to-lms-data?p=1681159#post1681159

darrell-k commented 6 months ago

Won't fix - it would become confusing in a performer search, where the composer was sometimes a performer and sometimes not.

daverz commented 6 months ago

I think the conflation of composers with artists in LMS is broken, but I guess I'm an old man yelling at clouds now. I'll have to look into whether I can at least make the composer a lighter color or something to reduce the visual clutter, but I suppose that's a skin function, not a server function.

darrell-k commented 6 months ago

I do separate composer from other contributors in this PR - I have to, as composer is part of the primary key of Work, so I have to join to the Contributors table twice - once for composer, and again for the other artists.

But we still have a problem: if searchng for (lets say) Bernstein, you're going to get a list of works, some composed by him, others where he is the conductor but not the composer, and we'd definitely want to show the composer against each work in that case.

However, a thought: via the "additional browse modes" Composer menu, we'd only be showing works composed by the searched for composer, so in that case, we could do away with the composer name on each line.

I'll reopen the issue.

darrell-k commented 6 months ago

Also, Material Skin does emphasise the first line of text (but it's going to need changes in other areas to fully take advantage of this PR). This example is the main Works listing - the wrong way around for your scenario, but can switch those around easily enough, depending on the menu we're looking at.

(Yes, I know it's sorting by first name - that's Qobuz imported data, and all I've changed in the import is to add Work, it going to need more work)

image

daverz commented 6 months ago

It's the second line of text, the work title, that I'd want visually emphasized. I'll have to look into how to to do customization in Material. I assume there's some CSS.

darrell-k commented 6 months ago

I was considering swapping the lines around, so although we're sorting by composer then work, making the work the first line. Does that make sense?

daverz commented 6 months ago

It doesn't make sense to me to have it second (and while there are locales that read right-to-left, I don't know of any that read bottom to top.). If composer must be in the entry, I think the order should duplicate the hierarchy in the menu. Could this be configurable eventually?

darrell-k commented 6 months ago

Configurable - yes, I thought I'd mentioned this, but maybe it was only over on the PR discussion with Michael. I think we need an equivalent of the Title Format options for works:

Screenshot from 2024-03-16 16-47-44