nus-pe-bot
commented
1 year ago Team's Response
According to the CS2113/T requirements, we are not able to store a database of modules and hence cannot check that if the module is actually valid and exists. Hence, our team has already done its best by limiting the number of characters that the user can input for module code to be 6-10 as valid modules are only of that certain length.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Ability to grade non gradable mods.
The user guide mentions that some letter grades are exempted. However, it does not warn up about grading mods with no letter grade, Perhaps it could be updated to warn against this behaviour.
[original: nus-cs2113-AY2223S2/pe-interim#1594] [original labels: severity.Low type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
According to the CS2113/T requirements, we are not able to store a database of modules and hence cannot check that if the module can actually obtained a letter grade or should only be given CS/CU. Moreover, the user will not obtain a letter grade for said modules and hence would not key them in.
However, we do feel that this is an important feature and will be implemented in future iterations of the program
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
It is stated to check NUSMods to ensure that the module is valid before adding. But I am still able to add the invalid mod even though it is not listed in NUSMods.
Perhaps it would be better if there is a basic list of all the mods stored locally so the application can do a simple cross check with the list?
Justification: This does not affect my usage of the application. Hence it is listed as low severity.