search

darrencroton / sage

Home of the Semi-Analytic Galaxy Evolution (SAGE) galaxy formation model
MIT License
21 stars 21 forks source link

The values of FoF_MaxGals and MaxGals #5

Closed diyiliaoya closed 3 years ago

diyiliaoya commented 7 years ago

Hi Darren,

In load_tree() function, you both set MaxGals and FoF_MaxGals to 10000. Why 10000? Is there any particular reason?

Cheers, Shijie

darrencroton commented 7 years ago

Basically to set up the structures/arrays and for memory. You can change this to whatever is reasonable for your simulation(s). Usually best to set it lower so you're not wasting resources, to the degree that you can.

diyiliaoya commented 7 years ago

Got it! Thank you!

darrencroton commented 7 years ago

No problem. Good luck!

manodeep commented 7 years ago

A note that you can set FoF_MaxGals to a lower value; and if more memory is required, the code will re-allocate in increments of 10000. This was added in pull request #4 (commit 0ca9ce12b87742c6228da898fe693ceb0cce1c6f, in core_build_model.c)

darrencroton commented 3 years ago

Based on the above discussion, i'll close this issue. Let me know if that's not ok @diyiliaoya .