darrenjennings / vue-autosuggest

🔍 Vue autosuggest component.
https://darrenjennings.github.io/vue-autosuggest
MIT License
621 stars 91 forks source link

feat: Add events @opened and @closed #181

Closed BerniML closed 4 years ago

BerniML commented 4 years ago

New showRenderedSuggestions and hideRenderedSuggestions events to facilitate event handling when suggestions appear and disappear

178 enhancement

What: feature #178 enhancement

Help control from the parent component when this suggestions are being shown/hidden, in case any more logic must be applied form the parent.

Checklist:

Didn't find how to add this 2 new events in events table of the Readme.md file, is it referenced in another file?

codecov-io commented 4 years ago

Codecov Report

Merging #181 into master will increase coverage by 0.34%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   85.11%   85.46%   +0.34%     
==========================================
  Files           1        1              
  Lines         168      172       +4     
  Branches       47       48       +1     
==========================================
+ Hits          143      147       +4     
  Misses         11       11              
  Partials       14       14              
Impacted Files Coverage Δ
src/Autosuggest.vue 85.46% <100.00%> (+0.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eddb82d...216faa9. Read the comment docs.

darrenjennings commented 4 years ago

@BerniML btw, I added an events section very recently, so should be straightforward now on where to add these new events.

BerniML commented 4 years ago

@darrenjennings I made the changes requested:

  1. Simplified names for the events
  2. Moved the emitters in the isOpen watcher
  3. Completed the reame with the new events information