darrenjennings / vue-autosuggest

🔍 Vue autosuggest component.
https://darrenjennings.github.io/vue-autosuggest
MIT License
621 stars 91 forks source link

Fix/a11y role combobox #194

Closed 42tte closed 4 years ago

42tte commented 4 years ago

What: Fixes usage of wai-aria role combobox.

Why: Adding a wai-aria role to an element overrides that elements native role and semantics. Meaning the input text field is no longer presented as an input text field but as a combobox.

How: Implemented the combobox according to the documentation https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html

Checklist:

codecov-commenter commented 4 years ago

Codecov Report

Merging #194 into master will not change coverage. The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   85.14%   85.14%           
=======================================
  Files           1        1           
  Lines         175      175           
  Branches       51       51           
=======================================
  Hits          149      149           
  Misses         11       11           
  Partials       15       15           
Impacted Files Coverage Δ
src/Autosuggest.vue 85.14% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33dd54e...1b24406. Read the comment docs.

darrenjennings commented 4 years ago

Thanks for this @42tte! Looks like a great change, and I'm surprised this wasn't caught sooner. Either way, I added a codecov yaml as it seems the bot is failing the patch phase. I think it's because of all the white space changes. If you rebase latest master I think it should trigger a new codecov run and disable the patch phase entirely.

42tte commented 4 years ago

@darrenjennings Thank you for the super fast response! Could I please ask for a npm publish as well 😀

darrenjennings commented 4 years ago

@42tte yes sorry about that, thought I did. 2.2.0 now available on the registry!