darrenjennings
commented
2 years ago hey thanks @djw for the work! I have not been maintaining this repo so appreciate the help. Would you be interested in helping me as a co-maintainer? I can try and get to your PR for review but could be good to have some extra help triaging tickets and working on new releases.
For this PR specifically, I am worried about the react-syntax-highlighter_languageshighlight deps, there's so many of them and I imagine we don't need all the languages (especially all of them checked into source control). Looks like v6 tree shakes them https://github.com/storybookjs/storybook/issues/9282. I was actually thinking of removing storybook because I didn't always find it super helpful and was more of a chore to maintain. Seems like you get some value out of it so happy to keep it. If we can't remove all of the built output files then I can approve and we can check in for now and hopefully remove when we migrate to v6.
djw
Note: builds on top of #225 — I'll leave this as draft until that PR is merged.
What:
Updates Storybook to v5.
Why:
Storybook v3 is very old now, and I'm attempting to modernise the project ahead of contributing changes to the component itself. Storybook v6 required more substantial changes, so I've left that for another PR.
How:
Fairly straightforward upgrade to Storybook v5, which also required an update to vue-loader v15. There's currently a checked-in version of the generated docs, so I've updated those files too.
I also updated
css-loader, though that wasn't strictly necessary.Checklist: