darrenjennings / vue-autosuggest

🔍 Vue autosuggest component.
https://darrenjennings.github.io/vue-autosuggest
MIT License
621 stars 91 forks source link

Added touch event support #69

Closed stripathix closed 6 years ago

stripathix commented 6 years ago

What: Added touch event support

Why: The @Selected event was not firing for iOS hybrid apps.

How: Added listeners for touchstart events and removed it before destroying of the component.

Checklist:

codecov[bot] commented 6 years ago

Codecov Report

Merging #69 into master will decrease coverage by 0.35%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   81.71%   81.35%   -0.36%     
==========================================
  Files           1        1              
  Lines         175      177       +2     
  Branches       52       52              
==========================================
+ Hits          143      144       +1     
- Misses         11       12       +1     
  Partials       21       21
Impacted Files Coverage Δ
src/Autosuggest.vue 81.35% <50%> (-0.36%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f562427...1aa3091. Read the comment docs.

stripathix commented 6 years ago

@darrenjennings did you tried steps in below comment to reproduce it on Chrome Dev tools.

https://github.com/Educents/vue-autosuggest/issues/67#issuecomment-428875386

darrenjennings commented 6 years ago

@stripathix yes I did. I was not able to reproduce on latest version of chrome and even with firefox touch emulator

darrenjennings commented 6 years ago

Closing for now until we can find reproducible steps.