Argument usage display should include default values

darrenlafreniere / lafarren-image-completer

Implementation of the research titled: "Image Completion Using Efficient Belief Propagation via Priority Scheduling and Dynamic Pruning"

http://www.lafarren.com/image-completer/

GNU General Public License v3.0

32 stars 18 forks source link

Argument usage display should include default values #31

Open daviddoria opened 13 years ago

daviddoria commented 13 years ago

I tried to run with -sw 2 -sh 2 to make the patch size small but I get:

Invalid settings:

lattice gap width ( 2) is less than 0
lattice gap height ( 2) is less than 0

I see that the min is 4. I guess there is a problem with the error output then, it should say (2 < 4) not (2 < 0).

daviddoria commented 13 years ago

Currently some defaults are hard coded in Settings.cpp, some are in LfnIcSettings.h. They are all retrieved from the user in the AppData constructor which calls SettingsConstruct in Settings.cpp. But all of the information about the user inputs is in CommandLineOptions? Phew, this is hard to follow!

Would it be possible to combine all of these into a Settings class which sets the defaults, stores the settings, and also knows how to get them from the user?