darrenlafreniere / lafarren-image-completer

Implementation of the research titled: "Image Completion Using Efficient Belief Propagation via Priority Scheduling and Dynamic Pruning"
http://www.lafarren.com/image-completer/
GNU General Public License v3.0
32 stars 18 forks source link

Why is ImageFloat scaled to (0,1)? #44

Open daviddoria opened 13 years ago

daviddoria commented 13 years ago

There are some "255 specific" conversions leading in and out of this class. Are these necessary? (Diving by 255 upon entry and clamp01-ing and multiplying by 255 upon exit).

darrenlafreniere commented 13 years ago

This was preserved from Tommer's Poisson code. Whether or not the in/out transformation can be junked would need some testing.

daviddoria commented 13 years ago

Oh, great. The Poisson stuff definitely doesn't require that - Assign it to me, I'll look into it.