search

darrenlafreniere / lafarren-image-completer

Implementation of the research titled: "Image Completion Using Efficient Belief Propagation via Priority Scheduling and Dynamic Pruning"
http://www.lafarren.com/image-completer/
GNU General Public License v3.0
32 stars 18 forks source link

Includes from AppData.h #46

Open daviddoria opened 13 years ago

daviddoria commented 13 years ago

There are includes like this in image-completer-cmd/AppData.h

include "LfnIcImage.h"

but LfnIcImage.h is actually in image-completer-lib

I fixed this originally by adding "image-completer-lib" to the list of include directories, but I think a more correct fix would be to change it to

include "image-completer-lib/LfnIcImage.h"

Surely there are many more like this as well. Thoughts?

daviddoria commented 13 years ago

image-completer-lib, image-completer-cmd, and tech should be treated as separate projects. The include_path should be separate for each of them and therefore this is not necessary.

daviddoria commented 13 years ago

I think the correct way to conceptually build this with cmake is to use SUBDIRS and have a CMakeLists.txt file in each directory. Then I believe my concern disappears. I'll give this a shot.