search

darrenlafreniere / lafarren-image-completer

Implementation of the research titled: "Image Completion Using Efficient Belief Propagation via Priority Scheduling and Dynamic Pruning"
http://www.lafarren.com/image-completer/
GNU General Public License v3.0
32 stars 18 forks source link

Guarding Poisson stuff #6

Closed daviddoria closed 13 years ago

daviddoria commented 13 years ago

In Compositor.cpp, if I do something like this:

ifdef USE_POISSON

    patchimageSourceFactory = new PatchTypePoisson::Factory;

else

    #error "USE_POISSON is disabled!"

endif

it doesn't make sense because it will throw the error or use the Poisson patches. Should it just be

ifdef USE_POISSON

    patchimageSourceFactory = new PatchTypePoisson::Factory;

endif

?

darrenlafreniere commented 13 years ago

Definitely the latter. Maybe

else

pragma message("blah")

daviddoria commented 13 years ago

Done.