darrenlafreniere / lafarren-image-completer

Implementation of the research titled: "Image Completion Using Efficient Belief Propagation via Priority Scheduling and Dynamic Pruning"
http://www.lafarren.com/image-completer/
GNU General Public License v3.0
32 stars 18 forks source link

PIXEL_DIMENSION not defined #72

Open daviddoria opened 13 years ago

daviddoria commented 13 years ago

With a fresh clone, I get this error:

image-completer-lib/api/LfnIcImage.h:97:51: error: expected primary-expression before ‘;’ token

That line is:

static const int NUM_CHANNELS = PIXEL_DIMENSION;

The problem is that PIXEL_DIMENSION is not set if USE_ITK=OFF

I suggest moving this line:

set(PIXEL_DIMENSION 3 CACHE STRING "Dimensionality of pixels?") #cmake doesn't have an "INT" variable type, so treat it as a string

outside of the if(USE_ITK) conditional, with a comment like:

ITK can support ND pixels, but even with Wx, this needs to be set to 3

raboof commented 8 years ago

The interesting thing is PIXEL_DIMENSION is defined (otherwise LfnIcImage.h would use a fallback), but it's defined to an empty string...