search

darrenldl / blockyarchive

Blocky archive - multithreaded archiver offering bit rot protection and sector level recoverability
MIT License
95 stars 4 forks source link

Update encode core to rely on data bytes encoded as input file size instead maybe #242

Closed darrenldl closed 5 years ago

darrenldl commented 5 years ago

Right now when encoding blank files, the input file size obtained would be 1, while data byte count would be 0.

This causes decoding to fail as blkar will truncate the output blank file to be 1 in size, even though the size should stay at 0.

The incorrect file size calculation seems to be exclusive to 0 length files, so not extremely critical as normally files to be encoded are not blank.

The other way of fixing would be finding a more accurate way of determining file size.

Will patch this in a few days when I've thought through which fix is better.