search

darrida / py-shinylive-authentication

Shinylive Authentication Package for creating, expiring, and managing auth sessions
MIT License
1 stars 0 forks source link

4 logout bug specific use cases #5

Closed darrida closed 4 months ago

darrida commented 4 months ago

Tests passed.

Summary by Sourcery

Fix notification display issues by adding unique IDs to session expiration and login warning messages. Enhance session management by freezing the token upon expiration. Introduce a new GitHub Actions workflow to run tests across multiple browsers. Add extensive tests for login and logout scenarios.

Bug Fixes:

Enhancements:

CI:

Tests:

sourcery-ai[bot] commented 4 months ago

Reviewer's Guide by Sourcery

This pull request addresses specific use cases for the logout functionality by enhancing the notification system and session management in the authentication flow. It introduces comprehensive test coverage for various login and logout scenarios using Playwright and PyTest. Additionally, a GitHub Actions workflow is added to automate the testing process across different browsers.

File-Level Changes

Files Changes
tests/test_app.py
tests/model.py		 Introduced comprehensive test coverage for login and logout functionalities using Playwright and PyTest.
src/shinylive_auth.py
tests/test_app.py		 Enhanced notification handling and session management in the authentication flow, and added corresponding tests.
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.