search

darrinhenein / VerticalTabs

Firefox add-on for arranging tabs vertically
https://addons.mozilla.org/firefox/addon/108862/
194 stars 28 forks source link

Scrolling error with pinned tabs #10

Open mbaz opened 9 years ago

mbaz commented 9 years ago

If I have more tabs than fit without scrolling, and then I pin a tab, then I can no longer scroll all the way up to the top tab. Also, the tab label gets shifted to the left and overlaps the tab icon.

This is on Firefox 32.0.3 and Vertical Tabs 0.2.

jsantell commented 9 years ago

I see this in nightly (36) as well

AWilyFox commented 9 years ago

There is a workaround for the scrolling issue. Use the patch in issue #8 :

--- a/skin/linux/linux.css  2014-09-01 19:16:43.300756000 +0300
+++ b/skin/linux/linux.css  2014-09-01 19:17:00.958383000 +0300
@@ -19,8 +19,8 @@
     margin: 0 !important;
     padding: 1px 0 !important;
     height: 24px !important;
-    min-height: 24px !important;
-    max-height: 24px !important;
+    min-height: 21px !important;
+    max-height: 21px !important;
 }

 .tabbrowser-tab[selected="true"],
mbaz commented 9 years ago

@AWilyFox Doesn't seem to work for me on Firefox 34.0.5. I applied the patch, ran make, and reinstalled the xpi. Should I have done anything else?