search

darrinhenein / VerticalTabs

Firefox add-on for arranging tabs vertically
https://addons.mozilla.org/firefox/addon/108862/
194 stars 28 forks source link

Minimum Width, Larger Hit Size on Sidebar Splitter #3

Closed robcee closed 9 years ago

robcee commented 9 years ago

This PR addresses a couple usability annoyances I found. 1st, this sets a minimum width so users can't collapse the sidebar into an unhittable, unresizable, 0px unspace. I used 40px which keeps the favicon still visible. 2nd, added a 3px invisible hit region to the sidebar splitter so it's easier to grab. Stolen gratuitously from our devtools sidebar css.

Did some minor cleanup of osx.css. Restored vvuk to the Creator of this addon, changed the id to be reflective of what it is (and not who), and bumped the version number ever-so-slightly indicating it's forked, updated and much-improved status.

Oh yeah! Changed the Makefile to produce an XPI named "VerticalTabs.xpi" in the parent folder. This might be contentious since the release won't end up in the same directory, but version controlling zipped files in git seems kinda silly. When this eventually moves to AMO, we might prefer this as a build procedure.

Please accept me! <3

seriousben commented 9 years ago

:sweet_potato:

robcee commented 9 years ago

🐣

darrinhenein commented 9 years ago

Thanks Rob :)

robcee commented 9 years ago

Thank you for reinvigorating this! I have a couple of other things I want to try out around resizing.

On Jul 24, 2014, at 2:30 PM, Darrin Henein notifications@github.com wrote:

Thanks Rob :)

— Reply to this email directly or view it on GitHub.