nus-pe-bot
commented
1 year ago Team's Response
This was intended. If we restrict it to a certain time before it can be marked, this would be overzealous. It is a matter of personal opinion of whether 1 hour or 2 hours is too early(?)
This would severely lower the testability of the product since each time the tester tests the application it would give a different result depending on the tester's current time.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: Restricting the time it can be marked would not be overzealous and would in fact be well within expectations of the product. In addition, such restriction can also help prevent users from marking the wrong students and would be welcomed by users. (i.e User has 2 student for the day, 1 at 9 am other at 3pm, user want to mark 1, but accidentally do mark 2 due to typo. This restriction will prevent user from marking 2.)
I understand that 1 or 2 hour might be a personal opinion, however being able to mark an 11pm lesson at 8 am seems a little off doesn't it? 1 or 2 hour was merely a suggestion and that a certain time restriction (decided by the team) should still be set.
Regarding testability, product can still be tested by changing system time within the OS of the tester.
at 4:44pm, I am able to mark the attendance of a student at 10pm, doesn't make much sense to be able to do so. If mark like 1 hour early I find that still acceptable, but about 5hour + early seems a little much