darrylb123
commented
5 years ago Sean, Great work. Looks very interesting even though I couldn't code Python to save myself. I'm very interested in merging this work but it at least has to work like the original. Just tried the command line usbrelay and it did not output anything. A quick glance at the code shows it is not designed to print anything.
The library also has the state disabled in an #ifdef DEBUG
if DEBUG == 1
fprintf(stderr, "Device Found\n type: %04hx %04hx\n path: %s\nserial_number: %ls", cur_dev->vendor_id, cur_dev->product_id, cur_dev->path, cur_dev->serial_number); fprintf(stderr, "\n"); fprintf(stderr, " Manufacturer: %ls\n", cur_dev->manufacturer_string); fprintf(stderr, " Product: %ls\n", cur_dev->product_string); fprintf(stderr, " Release: %hx\n", cur_dev->release_number); fprintf(stderr, " Interface: %d\n", cur_dev->interface_number);
// The product string is USBRelayx where x is number of relays readto the \0 in case there are more than 9 fprintf(stderr, " Number of Relays = %d\n", relay_boards[i].relay_count);
//Print the individual relay status
for (int j = 0; j < relay_boards[i].relay_count; j++)
{
if (relay_boards[i].state & 1 << j)
{
printf("%s_%d=1\n", relay_boards[i].serial, j + 1);
}
else
{
printf("%s_%d=0\n", relay_boards[i].serial, j + 1);
}
}endif
While I am keen to optionally disable debug messages they should be enabled with a command line flag.
Before merging, the usbrelay utility (which everyone uses at this point) should work the same as the old version. It's fine to leave the old debugging output for the moment.
Thank you again for your fine work. Happy to assist. Regards Darryl
On Fri, Mar 1, 2019 at 5:41 AM SeanMollet notifications@github.com wrote:
I realize this is a pretty big pull request, but there really isn't anything out there that is convenient for accessing these boards from python. Yours was the cleanest code to start from, so I used it as a base, moved the guys to a library and implemented a python extension on top of that.
You can view, comment on, or merge this pull request online at:
https://github.com/darrylb123/usbrelay/pull/27 Commit Summary
- Split this into functions, so it can be converted to a library and a command line app
- Converted to a shared library
- Works from python!
- Turned off debugging options
File Changes
- A .gitignore https://github.com/darrylb123/usbrelay/pull/27/files#diff-0 (4)
- M Makefile https://github.com/darrylb123/usbrelay/pull/27/files#diff-1 (25)
- A libusbrelay.c https://github.com/darrylb123/usbrelay/pull/27/files#diff-2 (268)
- R libusbrelay.h https://github.com/darrylb123/usbrelay/pull/27/files#diff-3 (40)
- A libusbrelay_py.c https://github.com/darrylb123/usbrelay/pull/27/files#diff-4 (198)
- A setup.py https://github.com/darrylb123/usbrelay/pull/27/files#diff-5 (13)
- A test.py https://github.com/darrylb123/usbrelay/pull/27/files#diff-6 (25)
- M usbrelay.c https://github.com/darrylb123/usbrelay/pull/27/files#diff-7 (264)
Patch Links:
- https://github.com/darrylb123/usbrelay/pull/27.patch
- https://github.com/darrylb123/usbrelay/pull/27.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/darrylb123/usbrelay/pull/27, or mute the thread https://github.com/notifications/unsubscribe-auth/AGcqVeo-tNoTCw1qCYztYUVa9c45zdhSks5vSDDUgaJpZM4bXlr0 .
SeanMollet
solvire
I realize this is a pretty big pull request, but there really isn't anything out there that is convenient for accessing these boards from python. Yours was the cleanest code to start from, so I used it as a base, moved the guts to a library and implemented a python extension on top of that.