search

darrylb123 / usbrelay

Control usb relay - based on hidapi
GNU General Public License v2.0
315 stars 98 forks source link

Various fixes #36

Closed wentasah closed 4 years ago

wentasah commented 4 years ago

Please see individual commit messages for more detailed description.

darrylb123 commented 4 years ago

Michael, Would you believe I committed a bug fix only yesterday that fixes at least one of your fixes. Can you debase on that and apply the others.

Darryl

On Tue., 28 Jan. 2020, 8:05 am Michal Sojka, notifications@github.com wrote:

Please see individual commit messages for more detailed description.

You can view, comment on, or merge this pull request online at:

https://github.com/darrylb123/usbrelay/pull/36 Commit Summary

  • Improve command line parsing
  • Improve error message
  • Fix problems with accesses to uninitialized memory
  • Do not print information for devices with denied permission

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/darrylb123/usbrelay/pull/36?email_source=notifications&email_token=ABTSUVNDQQEQOD7SFSJQLVLQ75LBLA5CNFSM4KMI4FT2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IJBY2JQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTSUVIXR6SPQHFYNW325NTQ75LBLANCNFSM4KMI4FTQ .

wentasah commented 4 years ago

Here you're with two non-conflicting commits. I'll probably send you some comments related to the remaining patches after I test your fixes.

Thanks.

darrylb123 commented 4 years ago

One of my fixes was to not print anything except the permission denied message. I expanded to error message to how to resolve the issue.

On Wed., 29 Jan. 2020, 08:23 Michal Sojka, notifications@github.com wrote:

Here you're with two non-conflicting commits. I'll probably send you some comments related to the remaining patches after I test your fixes.

Thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/darrylb123/usbrelay/pull/36?email_source=notifications&email_token=ABTSUVNARR4PM3BBQD7WTQ3RACV7RA5CNFSM4KMI4FT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKFFFCI#issuecomment-579490441, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTSUVNOVBXUCUOTYH6RT43RACV7RANCNFSM4KMI4FTQ .

darrylb123 commented 4 years ago

Michael, Sorry about the run around. Looked at your diff on a phone. It showed a diff against my changed code and I was confused. Your code looks ok to merge and doesn't conflict. I'll test.

On Wed, Jan 29, 2020 at 10:12 AM Darryl Bond darryl.bond@gmail.com wrote:

One of my fixes was to not print anything except the permission denied message. I expanded to error message to how to resolve the issue.

On Wed., 29 Jan. 2020, 08:23 Michal Sojka, notifications@github.com wrote:

Here you're with two non-conflicting commits. I'll probably send you some comments related to the remaining patches after I test your fixes.

Thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/darrylb123/usbrelay/pull/36?email_source=notifications&email_token=ABTSUVNARR4PM3BBQD7WTQ3RACV7RA5CNFSM4KMI4FT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKFFFCI#issuecomment-579490441, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTSUVNOVBXUCUOTYH6RT43RACV7RANCNFSM4KMI4FTQ .

darrylb123 commented 4 years ago

I've merged your code. I really do need to learn how to use git properly. I wanted to pull your changes in turn to look and test them.

Ended up going by the diff in github to merge then test.

Darryl

On Wed, Jan 29, 2020 at 10:49 AM Darryl Bond darryl.bond@gmail.com wrote:

Michael, Sorry about the run around. Looked at your diff on a phone. It showed a diff against my changed code and I was confused. Your code looks ok to merge and doesn't conflict. I'll test.

On Wed, Jan 29, 2020 at 10:12 AM Darryl Bond darryl.bond@gmail.com wrote:

One of my fixes was to not print anything except the permission denied message. I expanded to error message to how to resolve the issue.

On Wed., 29 Jan. 2020, 08:23 Michal Sojka, notifications@github.com wrote:

Here you're with two non-conflicting commits. I'll probably send you some comments related to the remaining patches after I test your fixes.

Thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/darrylb123/usbrelay/pull/36?email_source=notifications&email_token=ABTSUVNARR4PM3BBQD7WTQ3RACV7RA5CNFSM4KMI4FT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKFFFCI#issuecomment-579490441, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTSUVNOVBXUCUOTYH6RT43RACV7RANCNFSM4KMI4FTQ .