search

darrylb123 / usbrelay

Control usb relay - based on hidapi
GNU General Public License v2.0
315 stars 98 forks source link

create deb and whl packages #67

Closed PaulChanHK closed 2 years ago

PaulChanHK commented 3 years ago

Signed-off-by: PaulChanHK 19663576+PaulChanHK@users.noreply.github.com

wentasah commented 3 years ago

Hi,

what is the motivation behind this change? I don't have experience with wheel packages, but the Debian package is just a quick and dirty solution - there no dependencies and other metadata, that might be useful. Wouldn't it be better to copy the official Debian packaging (now a bit outdated) and update it? Building the package would then be as simple as running dpkg-buildpackage in the checked out repository?

darrylb123 commented 3 years ago

Thanks Michal, Not being a debian user, I have no idea how to get the Deb packages maintained. Haven't heard from the original package maintainer for a long time.

Darryl

On Mon, 28 Jun 2021, 11:13 pm Michal Sojka, @.***> wrote:

Hi,

what is the motivation behind this change? I don't have experience with wheel packages, but the Debian package is just a quick and dirty solution - there no dependencies and other metadata, that might be useful. Wouldn't it be better to copy the official Debian packaging https://packages.debian.org/sid/usbrelay (now a bit outdated) and update it? Building the package would then be as simple as running dpkg-buildpackage in the checked out repository?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/darrylb123/usbrelay/pull/67#issuecomment-869673306, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTSUVN5DV2X6E5G5QWVYBDTVBYPVANCNFSM47NOPHZA .

wentasah commented 3 years ago

My point was not to update the official Debian package, but to copy the packaging (that is the debian subdirectory) to this repository so that the Debian package can be easily created from every checkout of this repo. The advantage over the approach in this PR would be that the generated package would have correct dependencies, would be compiled with the same compiler switches (e.g. security hardening) as the rest of the distribution etc.

darrylb123 commented 3 years ago

Michal, Just looked at the patch. That seems to be what it does. Creates Deb dir copies stuff into it and runs a couple of Deb commands. Don't think it creates a complete package with python stuff as well though.

Darryl

On Tue, 29 Jun 2021, 8:21 am Michal Sojka, @.***> wrote:

My point was not to update the official Debian package, but to copy the packaging (that is the debian subdirectory http://deb.debian.org/debian/pool/main/u/usbrelay/usbrelay_0.4-2.debian.tar.xz) to this repository so that the Debian package can be easily created from every checkout of this repo. The advantage over the approach in this PR would be that the generated package would have correct dependencies, would be compiled with the same compiler switches (e.g. security hardening) as the rest of the distribution etc.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/darrylb123/usbrelay/pull/67#issuecomment-870084910, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTSUVOCUSGXNTFB3N4NS33TVDYVBANCNFSM47NOPHZA .

darrylb123 commented 2 years ago

The work on Debian and Fedora packaging replaces this request. Watch this space.