Closed mefuller closed 2 years ago
Thanks Mark, I will have to go back over it to remember how to build etc. Can't remember why the mqtt daemon wasn't working.
I'll check it out later today.
Darryl
On Mon, 25 Apr 2022, 6:40 am Mark E Fuller, @.***> wrote:
Here's a bunch of hacks and changes that should tidy things up. I tested locally with some AliExpress relay boards and everything works from the installation with the Python module being importable, etc. Builds checked out locally and on COPR (F35-37, all the architectures): https://copr.fedorainfracloud.org/coprs/fuller/test-builds/build/4307700/
Some additional thoughts: -once this is merged, we need to make a new code release/version and update the spec to that -maybe bump to 1.0? -if the mqtt/sysusers stuff isn't working still, perhaps drop that from the current package and save it for an update (but keep the information and instructions here on GH for end-users)
You can view, comment on, or merge this pull request online at:
https://github.com/darrylb123/usbrelay/pull/86 Commit Summary
- 6f86a03 https://github.com/darrylb123/usbrelay/pull/86/commits/6f86a032f74cdad9afc179b397c36708074b5a8b fix typo
- 16a25e9 https://github.com/darrylb123/usbrelay/pull/86/commits/16a25e95f6f6d63114f5326ee06f146afdffaf49 restore man and udev macros (still no error for man page - why?)
- 6f2543c https://github.com/darrylb123/usbrelay/pull/86/commits/6f2543c1adff273ec821e549ace5c097a5fe20dc add shebang as flagged by fedora-review
- 3004f8f https://github.com/darrylb123/usbrelay/pull/86/commits/3004f8fcbac8914dc99650b5d7ea99cb753481f8 restore working Python install; where to put test.py?
- 4b8d642 https://github.com/darrylb123/usbrelay/pull/86/commits/4b8d642cf449feea5297e7f3b5fa1398280c19ae bump to -3
- 73a5cc6 https://github.com/darrylb123/usbrelay/pull/86/commits/73a5cc663c81c7be97ca3889d504a93291d86089 fixups
- e29538b https://github.com/darrylb123/usbrelay/pull/86/commits/e29538bc51027d3b51e993cc40d0ccfea5eb0245 python shebang fix
- 0605e5d https://github.com/darrylb123/usbrelay/pull/86/commits/0605e5d863a76c37e7a1587011efc0a7011fdde5 try, try again
- f0d117e https://github.com/darrylb123/usbrelay/pull/86/commits/f0d117ee86b4d4c91a8dbe295846501cca7bad47 cleanup following jamezone.org suggestions: autochangelog, autorelease, numbering so, check python import
- 102d28f https://github.com/darrylb123/usbrelay/pull/86/commits/102d28f1dc2cd9a524fe8d6d2be937df6db3ea9e functioning Python build and install and check
- e42c6e9 https://github.com/darrylb123/usbrelay/pull/86/commits/e42c6e96ed3fc36bf85b27beee498e215fa70ea4 spec rev - intermediate
- f2922f1 https://github.com/darrylb123/usbrelay/pull/86/commits/f2922f1cb14b96adb75248e285fb1f1ecd3c0611 drop auto from spec so that we can use EL for now
- b3c76a1 https://github.com/darrylb123/usbrelay/pull/86/commits/b3c76a15a4896f5345e4e7ca9a6ceb69a243c52b spec seems to work; need to make new release and update in GH
File Changes
(9 files https://github.com/darrylb123/usbrelay/pull/86/files)
- A .gitignore https://github.com/darrylb123/usbrelay/pull/86/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947 (7)
- M Makefile https://github.com/darrylb123/usbrelay/pull/86/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52 (2)
- A changelog https://github.com/darrylb123/usbrelay/pull/86/files#diff-6665bc2f57c4a7045d347313a1566d91561ff2a3c9d17874a462ae73b7eb8593 (13)
- M rpm/usbrelay.spec https://github.com/darrylb123/usbrelay/pull/86/files#diff-ece00997139ab7c8f325a663be42eab1b02934c87491ee6941c1407588911f17 (39)
- M rpm/usbrelay.sysusers https://github.com/darrylb123/usbrelay/pull/86/files#diff-1d269a7464fddacc70ef7b9b53962e6f96e6d49891a1c57cfa7aeaef2337a8e7 (2)
- M setup.py https://github.com/darrylb123/usbrelay/pull/86/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7 (2)
- R test.py https://github.com/darrylb123/usbrelay/pull/86/files#diff-3665d65394f4f58a56a256ad6dd8621c68118d90fe56a19387e251c19cec2d2e (0)
- D usbrelay_py/init.py https://github.com/darrylb123/usbrelay/pull/86/files#diff-db44b069c6af190b10952a085a4331e46e58c3ecc64e6a9f013a718801dfb032 (8)
- M usbrelayd https://github.com/darrylb123/usbrelay/pull/86/files#diff-b2ec6efc683690afd0fbb35f71951afe4f5b4a31ff4d1f1389194fe4ddaeb0bc (2)
Patch Links:
- https://github.com/darrylb123/usbrelay/pull/86.patch
- https://github.com/darrylb123/usbrelay/pull/86.diff
— Reply to this email directly, view it on GitHub https://github.com/darrylb123/usbrelay/pull/86, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTSUVKRRQ543QNDJQY7B3DVGWWS7ANCNFSM5UGX7B5Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>
@darrylb123 absolutely no rush I'm sorry it took me so long to get back to this
Do you have any recommendation on how to implement library versioning? I already have the ability to query the git version from the library if it is built from git.
This won't work for the RPM though, since it's not built from git??
Will rpm tools ever support git rather than archive files?
Darryl
On Mon, 25 Apr 2022, 7:13 am Mark E Fuller, @.***> wrote:
@darrylb123 https://github.com/darrylb123 absolutely no rush I'm sorry it took me so long to get back to this
— Reply to this email directly, view it on GitHub https://github.com/darrylb123/usbrelay/pull/86#issuecomment-1107919563, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTSUVOQOQB4C355FDFCHALVGW2OVANCNFSM5UGX7B5Q . You are receiving this because you were mentioned.Message ID: @.***>
Pulled your request. BTW, the changes were merged back to master as the old python package stopped building on Ubuntu, but the new wheel package worked fine Now at 1.0
Darryl
On Mon, Apr 25, 2022 at 9:52 AM Darryl Bond @.***> wrote:
Do you have any recommendation on how to implement library versioning? I already have the ability to query the git version from the library if it is built from git.
This won't work for the RPM though, since it's not built from git??
Will rpm tools ever support git rather than archive files?
Darryl
On Mon, 25 Apr 2022, 7:13 am Mark E Fuller, @.***> wrote:
@darrylb123 https://github.com/darrylb123 absolutely no rush I'm sorry it took me so long to get back to this
— Reply to this email directly, view it on GitHub https://github.com/darrylb123/usbrelay/pull/86#issuecomment-1107919563, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTSUVOQOQB4C355FDFCHALVGW2OVANCNFSM5UGX7B5Q . You are receiving this because you were mentioned.Message ID: @.***>
Do you have any recommendation on how to implement library versioning? I already have the ability to query the git version from the library if it is built from git.
This won't work for the RPM though, since it's not built from git??
Will rpm tools ever support git rather than archive files?
Darryl
On Mon, 25 Apr 2022, 7:13 am Mark E Fuller, @.***> wrote:
@darrylb123 https://github.com/darrylb123 absolutely no rush I'm sorry it took me so long to get back to this
— Reply to this email directly, view it on GitHub https://github.com/darrylb123/usbrelay/pull/86#issuecomment-1107919563, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTSUVOQOQB4C355FDFCHALVGW2OVANCNFSM5UGX7B5Q . You are receiving this because you were mentioned.Message ID: @.***>
For version a.b, Fedora usually ships library.so, library.so.a, library.so.a.b and symlinks them together so that there's only one real file. The idea here is to support development better.
It's certainly possible to build and version by git commit and I can do that, but Fedora prefers (semantic) versioned releases
Here's a bunch of hacks and changes that should tidy things up. I tested locally with some AliExpress relay boards and everything works from the installation with the Python module being importable, etc. Builds checked out locally and on COPR (F35-37, all the architectures): https://copr.fedorainfracloud.org/coprs/fuller/test-builds/build/4307700/
Some additional thoughts: -once this is merged, we need to make a new code release/version and update the spec to that -maybe bump to 1.0? -if the mqtt/sysusers stuff isn't working still, perhaps drop that from the current package and save it for an update (but keep the information and instructions here on GH for end-users)