search

darryncampbell / darryncampbell-cordova-plugin-intent

General purpose intent shim layer for cordova appliations on Android. Handles various techniques for sending and receiving intents.
MIT License
86 stars 136 forks source link

Incompatible with apps using AndroidX #80

Closed moconnell9 closed 4 years ago

moconnell9 commented 4 years ago

Android support libraries have been moved to the androidx namespace. Please update.

https://developer.android.com/jetpack/androidx/migrate

darryncampbell commented 4 years ago

Thank you for the contribution! I am sorry about the delayed reply but I have just come back from holiday. Once I get through all my backlog that built up whilst I was away I will get review this.

darryncampbell commented 4 years ago

I did some testing and it works as long as the target SDK is 28 or higher, so I had to update my test application. I presume this is OK but just double checking this is expected behaviour before I merge the request? I have been out of touch with the wider Cordova community recently, hence my request for clarification that this is OK. Thanks again.

moconnell9 commented 4 years ago

Thank you for testing this so quickly! Yes 28 is standard right now. You may want to add <preference name="android-targetSdkVersion" value="28" /> but it's not required.

darryncampbell commented 4 years ago

Great, thanks! I will bump the version to 1.2.0 and post to npm