Closed aeppacher closed 4 years ago
This will be as a result of https://github.com/darryncampbell/darryncampbell-cordova-plugin-intent/pull/80. Can you please upgrade to Cordova Android 8.1 and ensure the application is being built with target 28 - I saw similar issues when I first tested (see comments on the pull request).
I can't explain why you can't pull 1.1.8, you should just be able to specify the following in your config.xml
<plugin name="com-darryncampbell-cordova-plugin-intent" spec="1.1.8" />
Hey Darryn. It looks like the switch from the old support libraries to the new androidx libraries is a delicate procedure right now. If you don't make the full switch, it causes issues, and there're still some plugins, and even Ionic 4's webview that aren't fully moved over yet. I added some pull requests that should help to close some of these gaps. (https://github.com/darryncampbell/darryncampbell-cordova-plugin-intent/pull/85 and https://github.com/darryncampbell/darryncampbell-cordova-plugin-intent/pull/86). I would recommend merging #85 for sure since it completes support for androidx with respect to your plugin. Please read my comment on #86, though. I think adding androidx as an option controlled by a variable, and probably turned off by default, may be a good idea considering the state of this transition.
People who have ^1.x.x
as their spec for this plugin will be bumped to 1.2.0
since semver considers it a minor release, so you may get a few messages in the meantime.
Thank you @cabaird ! I have made a bit of a dog's dinner of this but I think I have now corrected things. I have published version 1.3.0 to npm which does NOT contain support for Android X meaning people using ^1.x.x
should now be OK and I have moved all the Android X pull requests into version 2.0.0. I merged your https://github.com/darryncampbell/darryncampbell-cordova-plugin-intent/pull/85 but have a question about https://github.com/darryncampbell/darryncampbell-cordova-plugin-intent/pull/86 which I'll ask in that thread.
@aeppacher sorry about that, can you please confirm you are OK with 1.3.0? This should be functionally equivalent to 1.1.8
this solves this issue for me
For some reason cordova is ignoring my plugin version of 1.1.8 and forcing me to 1.2.0 which is problematic because I now get the following error when I have 1.2.0