Update build.gradle to use config from root project.

darryncampbell / react-native-datawedge-intents

React Native interface for Zebra's DataWedge Intent API

MIT License

43 stars 46 forks source link

Update build.gradle to use config from root project. #6

Closed itsyogesh closed 5 years ago

itsyogesh commented 5 years ago

Updated build.gradle to utilise the information from root project, instead of manually adding them. It also adds a fall back if there are no variables defined in the root project.

darryncampbell commented 5 years ago

Thanks for the contribution. I see a similar discussion at https://github.com/realm/realm-js/issues/1176 which suggests not removing the entire createJSModules() method but rather just removing the @Override annotation. What are your thoughts?

itsyogesh commented 5 years ago

Hey @darryncampbell

Thank you for checking out the PR. I just tested the code without the override and it seems to work, so we can definitely go that route.

darryncampbell commented 5 years ago

Thank you for the submission. Can you please push the variant without the Override (but keeping the createJSModules method), then I can merge this PR and have it pushed to npm.

itsyogesh commented 5 years ago

Hey @darryncampbell , just pushed the changes. Let me know if there is anything else we need for the merge.

darryncampbell commented 5 years ago

Thanks, merged and pushed new version, 0.1.2, to npm