Fix scrolling bug in Firefox 18-

darsain / sly

JavaScript library for one-directional scrolling with item based navigation support.

http://darsa.in/sly

2.87k stars 497 forks source link

Fix scrolling bug in Firefox 18- #170

Closed exside closed 9 years ago

exside commented 9 years ago

Fixes https://github.com/darsain/sly/issues/169

Source of problem is that Firefox below that version do not support any of the wheelEvents sly was trying to detect, but instead implement a custom MozMousePixelScroll event that has to be attached...

darsain commented 9 years ago

I know. Older Sly versions used events implemented in Firefox before wheel, but it was a bitch to normalize, so to simplify the code and save my sanity, in the latest commit that was touching scrolling, I dropped it and went with what is the current wheelEvents.

Honestly, Firefox 18 is 17 versions old, and has I'm sure less than 1% market share. I can't justify supporting it to myself.

exside commented 9 years ago

agree...but does it hurt to merge when already coded and tested?