search

darsain / sly

JavaScript library for one-directional scrolling with item based navigation support.
http://darsa.in/sly
2.87k stars 497 forks source link

deactivate item #251

Open spenya opened 8 years ago

spenya commented 8 years ago

Hi, I use the sly as a carousel of items, when i click on one of them I handle the onActive event to open a new tab on my app ... but if i close that tab and try to open it again (the same one) it does not work ... cos is still active and the event doesn't fire... is there some way to reset all active items??

sergey-dev commented 8 years ago

@spenya, I think you have something wrong with implementation logic. Try to solve it the other way.

It's obvious, that onActive callback is triggered only once in your case, only on element activation. If you try to click the same element one more time - onActive is not firing, as it's the same element is currently active, no changes happen.

My proposal for you, would be to bind your handler on the element itself, for example onClick, and not to involve the callback's logic of the Sly.

I propose to close this issue, as it's no issue to Sly, it's issue to your specific implementation.