search

darshan-hpc / darshan

Darshan I/O characterization tool
Other
57 stars 28 forks source link

split darshan-logutils.h into external and internal headers #793

Open carns opened 2 years ago

carns commented 2 years ago

Not a high priority, but it would be cleaner if the darshan-logutils.h file only provided definitions for things that library users should have access to.

It currently also provides access to internal data structures and function prototypes (like struct darshan_mod_logutil_funcs and DARSHAN_BSWAP64(), for example) that should only be used within logutils modules.

carns commented 2 years ago

Actually this is probably more work than just splitting the header. Utilities like darshan-parser actually make extensive use of calling mod_logutils[] function pointers directly. At a high level it's not obvious why this would be necessary.