darshan-hpc / darshan

Darshan I/O characterization tool
Other
56 stars 27 forks source link

MAINT: 3.12 support #959

Closed tylerjereddy closed 11 months ago

tylerjereddy commented 1 year ago

[skip cirrus]

tylerjereddy commented 1 year ago

Needed to add a few shims for FutureWarnings from newer pandas release as well.

tylerjereddy commented 1 year ago

There's still a type hinting error (mypy) to deal with: darshan/experimental/plots/plot_io_cost.py:180: error: "_AxesBase" has no attribute "legend" [attr-defined]

Maybe because of a newer matplotlib, I won't get to that today though.

shanedsnyder commented 11 months ago

I think the changes look good, thanks! The pandas future warning looks to be popping up elsewhere (#961, #963 ), so will be good to have that resolved.

Any objections to just adding 3.12 to the CI here to see what happens?

Aside from the outstanding CI error related to mypy, my only other suggestion is to add mention of the new place we need to maintain our version number (pyproject.toml) to RELEASE-CHECKLIST-PyDarshan.txt so we have a reminder as part of the release process.

tylerjereddy commented 11 months ago

Latest revisions pushed in are summarized below, but we'll have to wait and see if CI is happy:

* `plot_io_cost` now sets legend properties via the
raw axis object instead of via the twinned object (fixes
a `mypy` complaint)

* add Python `3.12` to the main CI matrix based on
reviewer feedback

* update release checklist to reflect version
number now maintained in `pyproject.toml` as well
shanedsnyder commented 11 months ago

Awesome, looks like everything is working here now, including the new 3.12 tests.

I'll go ahead and merge. Thanks!