search

darshan-hpc / darshan

Darshan I/O characterization tool
Other
56 stars 28 forks source link

Fix cibuildwheel process failing due to undeclared dynamic pyproject.toml metadata and missing test dependencies #968

Closed jakobluettgau closed 11 months ago

jakobluettgau commented 11 months ago

cibuildwheel builds fail complaining about a missing test dependencies (pytest) and dynamic properties in pyproject.toml not declared explicitly raising the following error:

/tmp/pip-build-env-9ywkt6zf/overlay/lib/python3.8/site-packages/setuptools/config/_apply_pyprojecttoml.py:75: _MissingDynamic:descriptiondefined outside ofpyproject.tomlis ignored

This pull request updates pyproject.toml and marks the affected fields as dynamic and adds missing test dependencies to resolve the issues.

shanedsnyder commented 11 months ago

Looks like still some failures in CI here. I've spent some time looking at this today and think we should either move completely to pyproject.toml or just pin setuptools to a prior version for the time being -- have a look at #969.

Assuming we get that working with all the quirks in PyDarshan, I'd just prefer that rather than maintaining multiple approaches.

jakobluettgau commented 11 months ago

Yeah I am all for consolidating and moving to pyproject.toml (there is also some old build pipeline artifacts we can drop then), this restored local builds with cibuildwheels for me, but I think the github workflow was setup differently anyway and just ran into the similar errors. I tested #969 and it works for me locally and seems to pass CI in github too, so this one can be closed and we move forward with #969 instead.