search

darshan-hpc / darshan

Darshan I/O characterization tool
Other
57 stars 28 forks source link

CI: initial setup of end-to-end regression CI #971

Closed shanedsnyder closed 10 months ago

shanedsnyder commented 10 months ago

We've long had some end-to-end (generating logs and analyzing log results using darshan-parser) regression tests in darshan-test/regression in our repo. These tests were traditionally run on a Jenkins CI instance at the ALCF. This PR attempts to fold those into a Github workflow that runs on PRs to main.

shanedsnyder commented 10 months ago

Okay, there's one outstanding test failure here, that I think corresponds to an actual bug that we'll need to resolve in Darshan. I'll attempt that in a separate PR so it's not buried in this one.

shanedsnyder commented 10 months ago

So, we should now have what used to be our "nightly" test running on PRs to main. I reduced the number of test cases down to the following:

Notably, I got rid of the tests of our compiler wrappers. We haven't really been updating those and they only work(ed) with MPICH, which supports the profiling configuration stuff already, so not sure it's something we should be concerned about going forward.

shanedsnyder commented 10 months ago

A fix for the remaining test failure is now in #975.

carns commented 10 months ago

Notably, I got rid of the tests of our compiler wrappers. We haven't really been updating those and they only work(ed) with MPICH, which supports the profiling configuration stuff already, so not sure it's something we should be concerned about going forward.

Unrelated to this PR, but I think at this point we should mark that method deprecated in the documentation (or maybe simply remove it outright). It was fragile even when it was actively maintained, and at this point I don't think it offers any advantage over the profile configuration method.