Closed gfairchild closed 5 years ago
Thanks a lot @gfairchild. I have fixed the 1
and 2
. The 3
is caused due to formatting issue so I may get to that later.
Great! Thank you, @darshanbaral. I can verify that the two errors were fixed.
@gfairchild, now everything should be fine.
Everything looks good on my end! Thank you for fixing this so fast. I really like the theme.
Thanks @gfairchild for the helpful comment.
First off, I really love this theme. I'm working on migrating my site to it. However, I discovered a few simple HTML5 validation issues that should be fixed.
https://gfairchild.nfshost.com/ is the current temporary testing site for my new homepage. https://validator.w3.org/nu/?doc=https%3A%2F%2Fgfairchild.nfshost.com%2F shows the HTML5 validation results. There are a few things that stick out:
https://fonts.googleapis.com/css?family=Alegreya|Lato
tohttps://fonts.googleapis.com/css?family=Alegreya%7CLato
.<dl>
tag requires both at<dt>
and<dd>
tag to be valid.layouts/partials/hobby.html
uses this tag incorrectly. There are a couple simple fixes you could do:<dl>
tag with a<ul>
tag. You could usestyle="list-style-type: none;"
to get rid of the bullet point and set the margin appropriately (e.g., this) to create a visually similar look that adheres to the HTML5 spec.description
parameter to each hobby element to enable a user to optionally specify additional details about their hobby.<h2>
and<h3>
headings are used incorrectly in a few spots.I love this theme, so keep up the good work!