darshanbaral / aafu

Portfolio theme with blog
https://themes.gohugo.io/aafu/
MIT License
47 stars 58 forks source link

Fix a few W3C HTML5 validation issues #1

Closed gfairchild closed 5 years ago

gfairchild commented 5 years ago

First off, I really love this theme. I'm working on migrating my site to it. However, I discovered a few simple HTML5 validation issues that should be fixed.

https://gfairchild.nfshost.com/ is the current temporary testing site for my new homepage. https://validator.w3.org/nu/?doc=https%3A%2F%2Fgfairchild.nfshost.com%2F shows the HTML5 validation results. There are a few things that stick out:

  1. The Google font is incorrectly specified. This isn't your fault; this is Google's fault. As you can see here, all that you need to do is change https://fonts.googleapis.com/css?family=Alegreya|Lato to https://fonts.googleapis.com/css?family=Alegreya%7CLato.
  2. The <dl> tag requires both at <dt> and <dd> tag to be valid. layouts/partials/hobby.html uses this tag incorrectly. There are a couple simple fixes you could do:
    1. You could replace the <dl> tag with a <ul> tag. You could use style="list-style-type: none;" to get rid of the bullet point and set the margin appropriately (e.g., this) to create a visually similar look that adheres to the HTML5 spec.
    2. You could add a new optional description parameter to each hobby element to enable a user to optionally specify additional details about their hobby.
  3. I haven't spent time to dig around, but it looks like <h2> and <h3> headings are used incorrectly in a few spots.

I love this theme, so keep up the good work!

darshanbaral commented 5 years ago

Thanks a lot @gfairchild. I have fixed the 1 and 2. The 3 is caused due to formatting issue so I may get to that later.

gfairchild commented 5 years ago

Great! Thank you, @darshanbaral. I can verify that the two errors were fixed.

darshanbaral commented 5 years ago

@gfairchild, now everything should be fine.

gfairchild commented 5 years ago

Everything looks good on my end! Thank you for fixing this so fast. I really like the theme.

darshanbaral commented 5 years ago

Thanks @gfairchild for the helpful comment.