fix: multiple-notifs-when-ongoing

zzjjaayy commented 4 months ago

Issue

The app right now doesn't keep track of the notification id thus creating multiple notifications in case of ongoing notifications like download progress.

Fix

Switched the primary key to keep track of the notificationId + packageName (composite primary key) instead of auto generating. {this helps in keeping the same notification object with updated progress}
Added Migration for db version bump from (1 to 2)

Video Recording

The start of the video shows a new notification being created at each change. The restart of the app is the install of the update and shows the progress update in the same notification.

https://github.com/darshanpania/Notificity/assets/54902986/5a44a60e-aa55-4656-a0b3-cf546037f7b6

darshanpania commented 4 months ago

@zzjjaayy I have 2 PRs on the UI bit that I need to first check and then I will come to this. Putting this on hold for a day or two. The problem is crucial for a fix, so I will circle back once I sort out the UI. 🙏

darshanpania commented 4 months ago

@zzjjaayy Pushed some changes to the main branch. Please rebase with the new changes

zzjjaayy commented 4 months ago

@darshanpania done.

darshanpania / Notificity

fix: multiple-notifs-when-ongoing #6

Issue

Fix

Video Recording