Enhancement press on log message can take to filter or exclude popup

darshanparajuli / LogcatReader

A simple app for viewing logs on an android device.

MIT License

580 stars 103 forks source link

Open michaelsam94 opened 5 years ago

michaelsam94 commented 5 years ago

when pressing on logcat message the user can filter or exclude with pressed log message

michaelsam94 commented 5 years ago

can put two items in popup menu when long press on message and when click on those items I put extra to intent with selected message

darshanparajuli commented 5 years ago

Hey Michael,

Thanks for the PR. Here's my initial feedback:

The FilterExclusion dialog does not need a title
- Filter or Exclude title seems redundant for a dialog with two items: Filter, Exclude
The log type on the Filter or Exclusion dialog (next screen) is not set after tapping on Filter or Exclude on FilterExclusion dialog
Log level filter/exclusion seems to be broken
Some code cleanup is needed