search

darsyn / ip

Immutable value object for IPv4 and IPv6 addresses, including helper methods and Doctrine support.
http://darsyn.github.io/ip/
MIT License
249 stars 21 forks source link

Upgrade PHP to 7.2, Strict Types, & Add Type Hinting #57

Closed zanbaldwin closed 2 years ago

zanbaldwin commented 4 years ago

Version Bump

Most importantly, should the version bump from 4.0 to 4.1 or 5.0 for this enhancement?

I mean, technically, this is a breaking change and backwards incompatible - BUT with the Composer version constraints, anyone using less than PHP 7.2 will never be offered the new version as an installation target and therefore will never install this package breaking their application... :woman_shrugging:

Notes on Failing Tests

The unit tests are failing on Travis CI for PHP 7.4 because the PHPUnit Mock Builder uses the deprecated method ReflectionType::__toString(). I cannot reproduce this failure locally.

zanbaldwin commented 2 years ago

No point in using newer language syntax when support for 5.6 to 8.1 can be achieved.