Closed vicb closed 10 years ago
Hi, @vicb, what's the status of this request? I can't automatically merge it, but aside from that, would it be ready? (Do you need to wait for the fix to angular/angular.dart#715 to become available on pub.dartlang.org?)
The 0.9.9 is buggy (the issue you mentionned) so I have put this on hold - I'll rebase next week on 0.10 and remove the WIP prefix to indicate when it's ready !
OK, makes sense. Thanks!
@vicb are you still planning to rebase on 0.10?
Kathy, I was off last week. I will handle this soon.
On 31 mars 2014 20:10:15 CEST, Kathy Walrath notifications@github.com wrote:
@vicb are you still planning to rebase on 0.10?
Reply to this email directly or view it on GitHub: https://github.com/angular/angular.dart.tutorial/pull/102#issuecomment-39121502
@kwalrath almost done, pending https://github.com/angular/angular.dart/issues/824 (is this is an ng issue, I'll push the updates tomorrow).
@kwalrath I think you can merge this one.
Due to the bug I mention in the previous comment, the clear button does not clear the filters (checkboxes) other than that everything works.
Ping me once/if you merge this so that i can update angulardart.org
OK, merging now. Please update angulardart.org accordingly. Thanks, @vicb!
Actually... Do you want to coordinate this merge with the angulardart.org merge? The less they diverge, the better. And I'd do both the merges, anyway.
OK, merged. Looking forward to the text update, @vicb.
Looking forward to the text update
Is that peer pressure ;)
Thanks for the merge, I'll update ASAP
Yes, @vicb, I'm big on peer pressure. :)
This https://github.com/angular/angular.dart/issues/715 needs to be fixed first