search

dart-archive / angular.dart

Legacy source repository. See github.com/dart-lang/angular
https://webdev.dartlang.org/angular/
1.25k stars 248 forks source link

Create dockerfile #1625

Closed cloudrifles closed 9 years ago

googlebot commented 9 years ago

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

chirayuk commented 9 years ago

I don't think file should not be part of AngularDart core.  The use of Docker is completely orthogonal to the use of AngularDart.

As an aside, you are specifically basing it on "dockerfile/ubuntu" (assumes that one wants to base it on the Ubuntu distribution—which is a fine choice, but not the only choice) and then installing Dart.  Perhaps you should base it on an image that has Dart installed. That brings in the question of keeping it updated with different versions of Dart.  And if you're locking down versions and creating such an image, you probably also want to "pub install".  AngularDart supports the stable and the dev versions of the Dart SDK and different version ranges of the packages.  I don't see the value added by this PR.

zoechi commented 9 years ago

There were often troubles to get the system set up so the unit tests can be run (For example pull requests where the contributor wasn't able to run the tests). I think it would be nice to have a Dockerfile for that. Here are links to Docker images which have Dart installed https://github.com/dart-lang/dart_docker