search

dart-archive / angular.dart

Legacy source repository. See github.com/dart-lang/angular
https://webdev.dartlang.org/angular/
1.25k stars 248 forks source link

<fix>(resource_url_resolver): Makes resolved URLs absolute #1648

Closed TedSander closed 9 years ago

TedSander commented 9 years ago

Makes resolved type URLs absolute instead of relative. When they are relative it is difficult to reuse components. Using pub serve relative URLs are resolved because pub does some magic to allow add symlinks to the packages directory where needed. In production relative URLs make it difficult to add file handlers to the locations that are needed, as the location will be determined based on the current browser path or route. It also makes the template cache harder to populate because the same resource may need to be served from two separate URLs.

Closes #1599

TedSander commented 9 years ago

If it makes more sense I can add a setting to make resolved URLs absolute to keep the previous logic.

googlebot commented 9 years ago

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!

mhevery commented 9 years ago

Achievement unlocked: CLA signature found!