search

dart-archive / angular.dart

Legacy source repository. See github.com/dart-lang/angular
https://webdev.dartlang.org/angular/
1.24k stars 248 forks source link

Update code_transformers and use transformer_test for tests #1759

Open jakemac53 opened 8 years ago

jakemac53 commented 8 years ago

The test helpers were split out from code_transformers into their own package. For the most part this just means changing any imports to package:code_transformers/tests.dart to package:transformer_test/utils.dart.

The only actual breaking change should be that the optional args to testPhases were changed to named args.

jakemac53 commented 8 years ago

I am looking into just sending a pr for this, if the dev environment is reasonable to set up ;)

lassedamgaard commented 8 years ago

Would be awesome to get this fixed as it prevents projects with a dependency on both test and angular from upgrading to dart 1.16 .

jakemac53 commented 8 years ago

I should have updated here, but last I checked working on this repo wasn't possible because I could not pub get due to version issues... not sure if somebody else can fix this or chime in with instructions on how to get things working.

lassedamgaard commented 8 years ago

https://github.com/angular/di.dart/issues/232 needs to be fixed first