search

dart-archive / angular.dart

Legacy source repository. See github.com/dart-lang/angular
https://webdev.dartlang.org/angular/
1.24k stars 248 forks source link

Update Angular to use package:observable #1761

Open tvolkert opened 7 years ago

matanlurey commented 7 years ago

@tvolkert I am seeing a pub error:

Package observe has no versions that match >=0.14.0 <0.15.0 derived from:
- angular depends on version ^0.14.0

@rkirov or @vsavkin can you help Todd merge this?

tvolkert commented 7 years ago

Weird - https://pub.dartlang.org/packages/observe is on version 0.14.0

tvolkert commented 7 years ago

Looks like this needs to wait until an update to polymer is published

https://github.com/dart-lang/polymer-expressions/pull/9 https://github.com/dart-lang/polymer-dart/pull/715

tvolkert commented 7 years ago

Actually, the problem seems to be with the introduction of the dependency on package:test (via package:observable and package:observe).

tvolkert commented 7 years ago

wtf?

$ pub get
Resolving dependencies... (2.7s) 
Package test has no versions that match >=0.12.3 <0.13.0 derived from:
- angular depends on version any
- code_transformers 0.3.1 depends on version >=0.12.1 <0.13.0
- guinness2 0.0.3 depends on version ^0.12.3
tvolkert commented 7 years ago

Huh, I actually get the following error trying to run pub get in against head...

$ pub get
Resolving dependencies... (10.6s) 
Package test has no versions that match >=0.12.3 <0.13.0 derived from:
- code_transformers 0.3.1 depends on version >=0.12.1 <0.13.0
- guinness2 0.0.3 depends on version ^0.12.3
tvolkert commented 7 years ago

There's a version tangle here that I don't have time to work through. If someone wants to land this PR, they'll have to update some version dependencies in pubspec.yaml

matanlurey commented 7 years ago

I think it's OK to keep Angular Dart 1 using the deprecated package for the time being - we aren't expecting any new users and old users are moving to Angular Dart 2.