dart-archive / angular_analyzer_plugin

WORK MOVED TO dart-lang/angular repository
https://github.com/dart-lang/angular/tree/master/angular_analyzer_plugin
68 stars 13 forks source link

Support `<ng-container>` properly. #628

Closed MichaelRFairhurst closed 6 years ago

MichaelRFairhurst commented 6 years ago

Also refactored converter.dart to share opening/close (name)span logic across the various special tag types (<normal>, <template, <ng-content>, <ng-container>.

Add an assert that all AstNodes get matched so this doesn't transparently happen again as new AngularAst nodes get added.

MichaelRFairhurst commented 6 years ago

ok feedback finally addressed! PTAL @leonsenft