search

dart-archive / angular_analyzer_plugin

WORK MOVED TO dart-lang/angular repository
https://github.com/dart-lang/angular/tree/master/angular_analyzer_plugin
68 stars 13 forks source link

Modify AngularErrorVerifier to pass InheritanceManager2 to analyzer. #643

Closed stereotype441 closed 5 years ago

stereotype441 commented 5 years ago

This is needed due to the change in the ErrorVerifier constructor in https://github.com/dart-lang/sdk/commit/8a2cfd86139c58c3378d903d76c43663c1c61b29.

MichaelRFairhurst commented 5 years ago

looks like a missing cast (since I have implicit downcasts turned off) and some test code we missed..

stereotype441 commented 5 years ago

@MichaelRFairhurst Can you recommend a fix? I see how to fix the missing cast but I don't understand the errors in the test code

MichaelRFairhurst commented 5 years ago

Oh, I misread the test failures.

Will fix those in a separate CL, that's an unrelated breakage.

stereotype441 commented 5 years ago

Ok, I believe I've addressed the error that's due to my CL. Should I go ahead and land this, or wait for your fix?

MichaelRFairhurst commented 5 years ago

I landed #644, retesting, but I'm pretty positive this will work.