Previous non-error tests didn't actually assert no errors were reported,
only that the elements were resolved. That worked under the previous
approach where the library scope was restricted, but that doesn't work
under the new aproach where resolution occurs regardless of the export
error.
After enabling the export error, the biggest issues found were:
summarized ExportedIdentifier has '' for prefix, not null, when
missing
identifer.name on a PrefixedIdentifier yields prefix.suffix rather
than just suffix.
One other edge case bug remained (prefixed.topLevelFn()), and then
added some tests for other edge cases, and did some other minor
refactoring like introducing new locals for better type promotion.
Previous non-error tests didn't actually assert no errors were reported, only that the elements were resolved. That worked under the previous approach where the library scope was restricted, but that doesn't work under the new aproach where resolution occurs regardless of the export error.
After enabling the export error, the biggest issues found were:
One other edge case bug remained (
prefixed.topLevelFn()), and then added some tests for other edge cases, and did some other minor refactoring like introducing new locals for better type promotion.