search

dart-archive / angular_analyzer_plugin

WORK MOVED TO dart-lang/angular repository
https://github.com/dart-lang/angular/tree/master/angular_analyzer_plugin
68 stars 13 forks source link

Remove an unnecessary and problematic cast #673

Closed bwilkerson closed 5 years ago

bwilkerson commented 5 years ago

The cast refers to a private class that is being renamed. Removing the cast doesn't have any effect because the invoked method only requires a TypeProvider.

MichaelRFairhurst commented 5 years ago

I think this was alread solved in #672, did you need that? (it's technically in a different branch)

bwilkerson commented 5 years ago

Yes. I'm trying to rename that class and running into conflicts. I'd be interested to understand why there are multiple branches and how to work with them.

MichaelRFairhurst commented 5 years ago

it passed so LGTM!