Closed guid-empty closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
ℹ️ Googlers: Go here for more info.
Thanks for the PR!
Really cool to see you are using it for this!
The API here is not stable, and in fact, is being refactored pretty heavily right now: https://github.com/dart-lang/angular_analyzer_plugin/compare/master...MichaelRFairhurst:for-google3#diff-3c5761f3b543b754d8b895d9c12c9198
I would say for now I would encourage importing an exact version and then use from src. (you have my permission because I know I've warned you it will change soon!)
After that refactor, I can stabilize the API for you! Two options there:
Do you have a preference there, and does that all sound good to you?
Like I said it's really cool to see you are planning on doing this! Let me know how I can make sure you get what you need from the code that will exist now and going forward :)
@guid-empty – all development for the plugin has moved to https://github.com/dart-lang/angular/tree/master/angular_analyzer_plugin
Please open a discussion there on the best way forward!
Hello!
This pull request is intended to close this issue: https://github.com/dart-lang/angular_analyzer_plugin/issues/687.
AngularDriver class (requestHtmlResult, requestDartResult methods) can be used outside the plugin to check quality of angular templates as external tool, for example, as hook to not commit dirty and not approved code to repository. Or to check the code quality in CI process before its publishing to production.
Please review and approve this export.
Regards, Andrey Smirnov