search

dart-archive / angulardart.org

Website for AngularDart, a web framework for Dart
angulardart.org
10 stars 18 forks source link

Import the tutorial code #14

Closed vicb closed 9 years ago

vicb commented 10 years ago

As the tuorial posts now live in this repo, it would be great to also import the code from the tutorial repo and remove this repo from GH.

Having 2 different GH repos is confusing and might lead to the doc being out of sync with the code.

kwalrath commented 10 years ago

That probably makes sense. Anyone have strong feelings, one way or another? @shailen, @chalin, @naomiblack, or @pavelgj?

vicb commented 10 years ago

Please import it. Having different repos is really a maintenance nightmare - and a nightmare for contributors. You would have to send 2 PRs to different repos when you want to change some tutorial code (which involve modifying the doc).

I had the case yesterday of sending a big PR (couple of hours of work) to a deprecated repo... very bad feeling - @pavelgj you know what I am talking about :)

chalin commented 10 years ago

The same happened to me; no fun. But, I don't think that we are establishing a precedent. The AngularJS tutorial is in a separate repo (as angular/angular-phonecat).

vicb commented 10 years ago

May be this particular tutorial is more stable ?

I've just commented an issue on the angular.dart repo: a user having issues with the tutorial code & recent angular... I told him to open an issue on the tutorial repo: 3 repos to check for an error.

The error could probably be solved by constraining the ng version -> 2 PRs, one for the md, one for the pubspec + they won't be merged in sync + ...

chalin commented 10 years ago

On the other hand, it seems conceptually cleaner to ask user's who are walking through the tutorial to get a copy of angular.dart.tutorial than angulardart.org.

To answer @kwalrath's question: don't have strong feelings either way. Both have +'s & -'s.

vicb commented 10 years ago

On the other hand, it seems conceptually cleaner to ask user's who are walking through the tutorial to get a copy of angular.dart.tutorial than angulardart.org.

Git has subtree-split if we want to go this way

chalin commented 10 years ago

Of course, another possibility would be to move the tutorial prose back to the tutorial repo (as it was before, though in the form of wiki pages). Those responsible for the site maintenance would have more to say about the feasibility, or not, of such a proposition.