Pub transformers are not running in the correct order

dart-archive / barback

An asset build system for Dart.

https://pub.dartlang.org/packages/barback

BSD 3-Clause "New" or "Revised" License

10 stars 9 forks source link

Pub transformers are not running in the correct order #48

Closed DartBot closed 9 years ago

DartBot commented 9 years ago

Issue by danschultz Originally opened as dart-lang/sdk#18872

Attachment: stitch_demo.zip (16.93 KB)

DartBot commented 9 years ago

Comment by kevmoo

Added Pub-Build, Area-Pub, Triaged labels.

DartBot commented 9 years ago

Comment by nex3

There are a few things making this hard for me to reproduce:

* The demo you've attached has a dependency override for "stitch" that's a local path dependency.

The existing version of "stitch" on pub.dartlang.org isn't compatible with Barback 0.13.0, despite its dependency declaration, since Stitcher.declareOutputs tries to read the primary input's contents.

Added NeedsInfo label.

DartBot commented 9 years ago

Comment by danschultz

Attachment: stitch_demo.zip (16.95 KB)

DartBot commented 9 years ago

Comment by nex3

The breaking change is mentioned in the changelog (http://pub.dartlang.org/packages/barback#changelog), which should be your primary source for determining what changed in a new release. We didn't include it in the mailing list post because at the time, Pub didn't support declaring transformers so we didn't expect many people to be using them.

Set owner to @nex3. Removed Pub-Build, Area-Pub labels. Added Area-Pkg, Pkg-Barback, Started labels.

DartBot commented 9 years ago

Comment by nex3

Fixed by dart-lang/sdk@3fafeaaa78081211d4a4a900e9e956918ee9e7b9 and dart-lang/sdk@287b119b7ac1fb1e88a66e31bb5b93e1497ab82f, released in barback 0.14.0+2 (although you'll need a new pub release to see the effects).

Added Fixed label.

DartBot commented 9 years ago

Comment by danschultz

Thanks for the prompt fix.