search

dart-archive / barback

An asset build system for Dart.
https://pub.dartlang.org/packages/barback
BSD 3-Clause "New" or "Revised" License
10 stars 9 forks source link

pub serve doesn't properly rebuild when the HTML of a Polymer element was changed #49

Closed DartBot closed 9 years ago

DartBot commented 9 years ago

Issue by zoechi Originally opened as dart-lang/sdk#19038

What steps will reproduce the problem? 1. I launch a Polymer app from DartEditor 2. I modify and safe an HTML file of a Polymer element DartEditor tools window writes 'Build completed successfully' but when I reload or kill and launch the Polymer app these changes are ignored. 3.

I have to kill pub serve and launch the Polymer app to get these changes applied.

What is the expected output? What do you see instead? Pub serve should properly rebuilt the app after changes (works for Dart, but not for Polymer HTML files)

What version of the product are you using? On what operating system? Dart VM version: 1.5.0-edge.36672 (Tue May 27 06:16:24 2014) on "linux_x64"

Please provide any additional information below.

DartBot commented 9 years ago

Comment by anders-sandholm

Removed Priority-Unassigned label. Added Priority-High, Area-Pub, Pub-Serve, Triaged labels.

DartBot commented 9 years ago

Comment by nex3

Can you include a zip or tar file of a simple package that reproduces the issue, including the pubspec.lock?

Added NeedsInfo label.

DartBot commented 9 years ago

Comment by zoechi

Sorry, all but a simple example I'll see if I can come up with something simpler...

I had the issue in this project: https://github.com/bwu-dart/bwu_datagrid/tree/04_model (branch 04_model)

I launch this file: https://github.com/bwu-dart/bwu_datagrid/blob/04_model/example/e04_model.html

and modify this file: https://github.com/bwu-dart/bwu_datagrid/blob/04_model/lib/components/bwu_column_picker/bwu_column_picker.html

I didn't have the issue somewhere else yet, but I also worked only on this project and only with this polymer-element since I upgraded to 1.5.0.

The pubspec.lock is included https://github.com/bwu-dart/bwu_datagrid/blob/04_model/pubspec.lock

I added these dependency_overrides to see if it improves anything dependency_overrides:   analyzer: 0.15.5   barback: 0.14.0+2   quiver: 0.18.2

DartBot commented 9 years ago

Comment by nex3

It looks like this is a barback bug.

Set owner to @nex3. Removed Area-Pub, Pub-Serve labels. Added Area-Pkg, Pkg-Barback, Started labels.

DartBot commented 9 years ago

Comment by nex3

Fixed in dart-lang/sdk@ed667e542c61fb42feb26b29c162cef93a665052, to be released in Barback 0.14.1. Note that you'll need a version of pub with this barback compiled in to see the effects of the fix.

Added Fixed label.