search

dart-archive / custom-element-apigen

Tool to generate Dart APIs for polymer custom elements written in Javascript
BSD 3-Clause "New" or "Revised" License
13 stars 13 forks source link

Add overrides #51

Closed dam0vm3nt closed 7 years ago

jakemac53 commented 8 years ago

Can you add this to the e2e test as well (that also helps serve as documentation). See the e2e_test folder.

jakemac53 commented 8 years ago

also format please :)

jakemac53 commented 8 years ago

Looks like this still needs a quick dartfmt

dam0vm3nt commented 8 years ago

yes, I forgot. Now it's formatted. (I've dart formatted all lib an e2e tests ...)

jakemac53 commented 8 years ago

Oh, the e2e_test folder shouldn't have been formatted :( (tests now fail). You can fix that by either modifying the test to remove all whitespace before comparing, or just undo the last commit and only format lib.

dam0vm3nt commented 8 years ago

Ouch you are right! Sorry. I'll fixit asap.

Il mar 9 ago 2016, 15:55 Jacob MacDonald notifications@github.com ha scritto:

Oh, the e2e_test folder shouldn't have been formatted :( (tests now fail). You can fix that by either modifying the test to remove all whitespace before comparing, or just undo the last commit and only format lib.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dart-lang/custom-element-apigen/pull/51#issuecomment-238560136, or mute the thread https://github.com/notifications/unsubscribe-auth/ACTD-gYEYQMcwcyNK7RIRgmfR_ncpL4bks5qeIa0gaJpZM4JWclE .

dam0vm3nt commented 7 years ago

@jakemac53 changes made on the #53 PR. Do you prefer them to be pushed here ?