search

dart-archive / custom-element-apigen

Tool to generate Dart APIs for polymer custom elements written in Javascript
BSD 3-Clause "New" or "Revised" License
13 stars 13 forks source link

Pkg compat #53

Open dam0vm3nt opened 8 years ago

dam0vm3nt commented 8 years ago

support for .packages file.

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

terrasea commented 7 years ago

I have signed the CLA

dam0vm3nt commented 7 years ago

k, tnx.

googlebot commented 7 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

terrasea commented 7 years ago

Yes I am okay with the commit I made being contributed to the project.

terrasea commented 7 years ago

All this just for a single line change :-)

dam0vm3nt commented 7 years ago

eh, the good news is that you have to do this only once for any google project. But the first time is cumbersome.

terrasea commented 7 years ago

True, but I can't help but see the funny side

terrasea commented 7 years ago

Um, I assume I've done what I need to do?

dam0vm3nt commented 7 years ago

Actually I don't know! I figure some google guy should approve your contribution ?

terrasea commented 7 years ago

Lets hope that's all that's needed.

dam0vm3nt commented 7 years ago

@jakemac53 made some minor fixes. Do you know also how to clear the CLA issue ? I think @terrasea has already signed it.

terrasea commented 7 years ago

Yes I have and I've also said I'm happy for my one line commit to be used. If that's not clear, I reiterate, I'm happy for my commits to be used in this pull request