Closed bwilkerson closed 6 years ago
In your PR, can you remove the stable
line here: https://github.com/dart-lang/dart2_fix/blob/master/.travis.yml#L10
Done
If it helps, what I'm thinking for the UI:
> dart2_fix
Checking project foo_bar...
lib/main.dart
line 23, deprecated Duration.ZERO
line 37, deprecated Duration.ZERO
lib/src/foo.dart.dart
line 23, deprecated Duration.ZERO
37 changes found.
and then:
dart2fix --apply
lib/main.dart
7 changes Duration.ZERO ==> Duration.zero
lib/src/foo.dart
1 change Duration.BAZ ==> Duration.baz
3 changes Duration.ZERO ==> Duration.zero
37 changes total.
In other words, a run of the tool w/o args will just indicate what changes it's found; a run of the tool with something like --apply
would actually perform the changes on disk (and indicate approx. what changed).
I would remove lines https://github.com/dart-lang/dart2_fix/blob/master/.travis.yml#L22 and 23 as well - the stable option, and the the dartfmt task.
Also done
That sounds like a reasonable UI. I'll refactor to support it.
Untested and incomplete. Just to make sure we're on the same page for the direction we're heading.